GH-127178: convert _sysconfigdata to a JSON file#127180
GH-127178: convert _sysconfigdata to a JSON file#127180FFY00 wants to merge 6 commits intopython:mainfrom
Conversation
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
|
The change seems useful indeed. Is this PR closed by accident @FFY00, or for some other reason? |
|
Thanks for the context! |
|
Is there anything still outstanding which would prevent us from making the JSON file the single source of truth? Distributing the same information in two different formats will inevitably lead to confusion. From the perspective of cross-compiling packages for mobile, if the JSON file isn't going to be used, then I'd prefer if it wasn't there at all. |
|
It's an implementation detail, so you could remove it if desired. The installed JSON file is just a reference output of
|
|
The problem is, if external build systems do start using it (which they probably will once they notice it, whether we encourage them to or not), then removing it will no longer be an option. So any tool which needs to alter this data (as we're doing for Android and iOS in cibuildwheel), will have no choice but to alter it in both files. |
|
I guess I'm just not clear about what the purpose of this file is. You say it's "meant to help ... build systems during cross compilation", but the general principle is that anything starting with an underscore should not be used externally at all. |
_sysconfigdatato a JSON file #127178